Skip to content

chore(docs): add lld mention for macOS to BUILD.md#102

Merged
cowboyd merged 2 commits into
bombshell-dev:mainfrom
tbeseda:main
Jul 1, 2026
Merged

chore(docs): add lld mention for macOS to BUILD.md#102
cowboyd merged 2 commits into
bombshell-dev:mainfrom
tbeseda:main

Conversation

@tbeseda

@tbeseda tbeseda commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

BUILD.md does not mention the lld requirement for macOS. Following the instructions means make fails even though the clang smoke test passes. lld is needed.

I couldn't find an existing issue. If you'd rather author your own changes to BUILD.md, feel free to close this - I just wanted to make a quick fix to a small issue available.

Type of change

  • Bug fix
  • Feature
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

These seem generic to other bombshell projects and don't apply here (deno test does pass).

  • All tests pass (pnpm test)
  • Files are formatted (pnpm format)
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset

AI-generated code disclosure

  • This PR includes AI-generated code

Opus 4.8 helped update the smoke test to also link and more closely match the commands used in make to catch other missing dependencies.

@pkg-pr-new

pkg-pr-new Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@bomb.sh/tty@102

commit: 34aa181

@codspeed-hq

codspeed-hq Bot commented Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 18 skipped benchmarks1

Comparing tbeseda:main (34aa181) with main (5b2124e)2

Open in CodSpeed

Footnotes

  1. 18 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (5e253a7) during the generation of this report, so 5b2124e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@cowboyd

cowboyd commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@tbeseda thanks! It looks like the markdown needs some formatting (deno task fmt). We should probably add something to AGENTS.md to run that before opening pull requests.

We'll have to look into the benchmarks as this did not change any actual code.

@cowboyd

cowboyd commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Here's a fix for the size checker #105

@tbeseda

tbeseda commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@cowboyd thanks for taking a look. I updated BUILD.md with deno task fmt

cowboyd
cowboyd approved these changes Jul 1, 2026
View reviewed changes

@cowboyd cowboyd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@cowboyd cowboyd merged commit 7a28d5d into bombshell-dev:main Jul 1, 2026
11 checks passed
@cowboyd

cowboyd commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

@tbeseda cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cowboyd cowboyd cowboyd approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbeseda @cowboyd